The bug in your script seems to stem from a misunderstanding of what happens when you evaluate an array in Boolean context. if(@array) {... doesn't test every single element against some implicit variable such as $_. All it does, is evaluate the array in scalar context, which returns the number of elements in the array. Therefore, if there are zero elements, the conditional will be false. If there are more than zero elements, it will be true.

Here are a couple of ways to do it. In terms of computational complexity, this first one is a linear growth-rate solution:

my $count = do {
    my %seen;
    @seen{@somenames} = ();
    my $c;
    foreach my $name ( @allnames ) {
      $c++ if exists $seen{$name};
    }
    $c;
};

[download]

This is a quadratic solution:

my $count;
foreach my $name (@allnames) {
  $count++ if grep { $_ eq $name } @somenames;
}

[download]

The first solution trades memory for computational efficiency; its rate of growth in memory requirements is linear, tied to the growth of @somenames. Its rate of growth in computational complexity is tied to the growth of @allnames+@somenames. Update: I've limited the duration of the memory requirement to a narrow scope; in theory Perl could reuse the memory consumed by %seen since it's falling out of scope at the end of the do{} block.

The second solution has constant memory requirements, but must run through "@somenames" one time for every element in @allnames. This could become very slow very fast, if the arrays grow. The second solution could, in principle, be improved upon by using List::Util::any. Unfortunately (or fortunately, depending on how you look at it), grep is highly optimized in ways that seem to be unavailable to XSUBS, so 'any' it often not a performance win, though its semantic purity may still make it a good alternative.


Dave

In reply to Re: check all elements of an array against another array... by davido
in thread check all elements of an array against another array... by tjo7777

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.