comment on

Dear Monks,

Once more I need your wisdom. I am processing files through arguments as input from the terminal. It is very important for me to process the files and store the data in are in correct order. I thought by using an array of arrays will solve my problem but it does not seem to be processed correctly.

Sample of code:

#!/usr/bin/perl

use strict;
use warnings;
use Data::Dumper;
use Fcntl qw(:flock); # import LOCK_* and SEEK_END constants

$| = 1;
my @value;
my @value_2;
my $i = 0;

sub first {

    foreach my $argnum (0 .. $#ARGV) {

    open (READ, "<" , $ARGV[$argnum])
        or die ("Could not open: ".$ARGV[$argnum]." - $!\n");
    
    flock(READ, LOCK_EX)
        or die "Could not lock '".$ARGV[$argnum]."' - $!\n";

    if (-z "".$ARGV[$argnum]."") {
        print READ "is empty!\n";
        # -z  File has zero size (is empty).
    }

    print "This is the \$ARGV[$argnum]: ".$ARGV[$argnum]."\n";

    while ( my @doc_read = <READ> ) {

        chomp @doc_read;

        foreach $_ (@doc_read) {
        my @result = split (':', $_);

        if (/^\s*$/) { # /^\s*$/ check for "blank" lines may contain s
+paces or tabs
            next;
        }

        push (@{ $value[$i++] }, $result[3]);
        }
        $i = 0 if eof;
    }

    close (READ)
        or die ("Could not close: ".$ARGV[$argnum]." - $!\n");
    }

    return @value;
}

sub second {
    
    foreach my $arg (@_) {

    open (READ, "<" , $arg)
        or die ("Could not open: ".$arg." - $!\n");

    flock(READ, LOCK_EX)
        or die "Could not lock '".$arg."' - $!\n";

    if (-z "".$arg."") {
        print READ "is empty!\n";
        # -z  File has zero size (is empty).
    }
    
    print "This is the \$arg: ".$arg."\n";

    while ( my @doc_read = <READ> ) {

        chomp @doc_read;

        foreach $_ (@doc_read) {
        my @result = split (':', $_);

        if (/^\s*$/) { # /^\s*$/ check for "blank" lines may contain s
+paces or tabs
            next;
        }

        push (@{ $value_2[$i++] }, $result[3]);
        }
        $i = 0 if eof;
    }

    close (READ)
        or die ("Could not close: ".$arg." - $!\n");
    }
    
    return @value_2;
}

my @result = &first();
my @result_2 = &second(@ARGV);

print "\nValues \@result\n";
print "@$_\n" for @result;
print "\nValues \@result_2\n";
print "@$_\n" for @result_2;
[download]

The problem appears that if files have different line numbers. I am trying to separate the arrays based on the file order.

Sample of sample.txt:

Line_1:Line_1_1:Line_1_2:Line_1_3:Line_1_4
Line_2:Line_2_1:Line_2_2:Line_2_3:Line_2_4
[download]

Sample of sample_2.txt:

Line_3:Line_3_1:Line_3_2:Line_3_3:Line_3_4
[download]

Sample of sample_3.txt:

Line_4:Line_4_1:Line_4_2:Line_4_3:Line_4_4
Line_5:Line_5_1:Line_5_2:Line_6_3:Line_5_4
Line_6:Line_6_1:Line_6_2:Line_6_3:Line_6_4
Line_7:Line_7_1:Line_7_2:Line_7_3:Line_7_4
[download]

Sample of output after processing the files:

Values @result
Line_1_3 Line_3_3 Line_4_3
Line_2_3 Line_5_3
Line_6_3
Line_7_3

Values @result_2
Line_1_3 Line_3_3 Line_4_3
Line_2_3 Line_5_3
Line_6_3
Line_7_3
[download]

It is very important for me to know the order stored in the array and the values to be placed on the correct position. I am going to apply more than 6 files on my experiment that will evolve mathematical calculations. So the ordered stored in the array it is very important for me.

Thank you all in advance for your time and effort to assist me.

I have created the same script with two different ways just in case that someone is interested in speed and process time as I was. I measured the difference and the second script is much much faster than the first one.

Update and solution:

I just needed to push all values in one array, and then push this array to a separate array. It sounds a bit confusing they way that I described it.

So here is the code that I used:

push (@value , $result[3]);

push (@array, [@value]);

# Important to empty the array for the next file!
@array = ();
[download]

All together as a solution:

#!/usr/bin/perl

use strict;
use warnings;
use Data::Dumper;
use Benchmark qw(:all); # For timming reasons
use Fcntl qw(:flock); # import LOCK_* and SEEK_END constants

$| = 1;

my @value_2;
my @array_2;

sub second {
    
    foreach my $arg (@_) {

    open (READ, "<" , $arg)
        or die ("Could not open: ".$arg." - $!\n");

    flock(READ, LOCK_EX)
        or die "Could not lock '".$arg."' - $!\n";

    if (-z "".$arg."") {
        print READ "is empty!\n";
        # -z  File has zero size (is empty).
    }

    while ( my @doc_read = <READ> ) {

        chomp @doc_read;

        foreach $_ (@doc_read) {
        my @result = split (':', $_);

        if (/^\s*$/) { # /^\s*$/ check for "blank" lines may contain s
+paces or tabs
            next;
        }

        push (@value_2 , $result[3]);
        }
        
        push (@array_2, [@value_2]);

    }
    @value_2 = ();

    close (READ)
        or die ("Could not close: ".$arg." - $!\n");
    }
    
    return @array_2;
}

my @result_2 = &second(@ARGV);

print Dumper(@result_2);
[download]

The solution includes only the second sub because the process time is much much smaller.

Seeking for Perl wisdom...on the process...not there...yet!

In reply to How to process several files with different line numbers by thanos1983

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.