Hello thanos1983,

I’m glad to see from your update that the script is now working as you want. However, I still have a couple of observations:

  1. You open the filehandle READ for reading ("<"), but then try to write to it:

    if (-z "".$arg."") {
    print READ "is empty!\n";

    [download]

    If the test ever succeeds (because the file is empty), the code will break.

  2. while ( my @doc_read = <READ> ) {

    [download]

    Assigning the output of the diamond operator to an array puts the operation into list context, which means the entire file is read on the first iteration of the loop. So there is no point in having a while loop here.

  3. Calling a subroutine by prefixing an ampersand ( &second(@ARGV); ) is usually a bad idea, unless you really need to disable prototyping, in which case you have to omit the trailing parentheses (see What's the difference between calling a function as &foo and foo()?). Prefer an ordinary subroutine call: second(@ARGV);

Hope that helps,

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

In reply to Re: How to process several files with different line numbers by Athanasius
in thread How to process several files with different line numbers by thanos1983

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.