Hi Monks! I am new to DB access via perl and would like some guidance on how to manage/improve exception handling for my code. I have included below the DB code from my overall script and I would greatly appreciate your input on this. 

my $server_name = 'test_server';
my $database_name = 'test_db';
my $database_user = '';
my $database_pass = '';

if($DB_insert =~ /true/i) {
    my $DSN = "driver={SQL Server};server=$server_name;database=$datab
+ase_name;uid=$database_user;pwd=$database_pass;"; 

    my $dbh = DBI->connect("dbi:ODBC:$DSN", {PrintError =>0, RaiseErro
+r =>1});

    eval {
        if (!$dbh) {            #testing connection to DB
            print "Could not connect to database: $DBI::errstr";
        }

        if($dbh) {
            print "Connected to DB!!";
        }

        my $sql = "INSERT INTO test_table VALUES ('test_env','$partner
+','$id','$filename','$date $time','$line_count')";                  

        my $sth = $dbh->prepare($sql);        
        $sth->execute();
    };
    if($@) {
        $dbh->disconnect();
        QuitProgram("DB Failure: $@");
    }
    
    $dbh->disconnect();
}

[download]

In reply to DB Exception Handling by sowais

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.