I have just looked over the code (this one, right?) and it seems to me that a better approach can be used to check for separators.

Currently you check at every character for the two possibilities (single or multi-byte separator): 

if (c == csv->sep_char || is_SEPX (c)) {

[download]

A better way would be to consider the multi-byte separator as a single-byte separator plus a tail: 

/* somewhere on the object constructor */
csv->sep_tail_len = sep_len - 1;
csv->sep_tail = sep + 1;
csv->sep_char = *sep;
...

/* then, on the parser */
if (c == csv->sep_char) {
    if (!csv->sep_tail_len ||
        ((csv->size - csv->used >= csv->sep_tail_len) &&
         !memcmp(csv->bptr + csv->used, csv->sep_tail, csv->sep_tail_l
+en))) {
        /* you have a separator! */

[download]
I think that would minimize the impact of supporting the extra multi-byte checks on the common single-byte separator case.

In reply to Re^2: Speeds vs functionality by salva
in thread Speeds vs functionality by Tux

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.