Hello monks,

I know enough perl to be bad; however I live in a unix userland and some things are more universally accepted than others, one of them being perl. I usually play around in php, but writing this sort of script in php seems wrong.

My goal was for it to be understandable and log songs played via pianobar to csv for use with other things. What ways could this be improved? Any feedback is appreciated.

//ulterior_modem

Script.

use strict;
use warnings;

# this holds all of the lines output by pianobar.
my @input = <STDIN>;

# lines parsed into hash.
my %data;

# file we want to write output to
my $file = '/home/ulterior/pandora.log';

# assembled CSV line.
my $line;

# last line of logfile.
my $lastline;

# remove newlines from end of all values in array.
chomp @input;

# build hash from contents of array.
foreach my $var (@input)
{
 (my $key, my $value) = split(/\=/, $var);
 $data{$key} = $value;
}

# check to see if all the field we want are defined.
if (defined($data{title}) &&
    defined($data{artist}) &&
    defined($data{album})  &&
    defined($data{songStationName})) 
{
# compose csv line with/without album art.
 if (defined($data{coverArt}))
 {
  $line = '"'.$data{title}.'","'.$data{album}.'","'.$data{artist}.'","
+'.$data{songStationName}.'","'.$data{coverArt}.'"'."\n";
 } else 
   {
    $line = '"'.$data{title}.'","'.$data{album}.'","'.$data{artist}.'"
+,"'.$data{songStationName}.'"'."\n";
   }
}
# check to see if log file exists.
if (-e $file)
{
# check to see if the last line is the same to avoid duplication.
 $lastline = qx/tail -n 1 $file/;
 if ($line eq $lastline)
 {
  exit(0);
 } 
# write csv line to file.
 else {
      open(HANDLE, ">>", $file);
      print(HANDLE "$line");
      close(HANDLE);
      }
}

[download]

Sample data.

artist=Bastille
title=Pompeii
album=Pompeii (Remixes) 
coverArt=http://cont-2.p-cdn.com/images/public/amz/9/5/3/6/800026359_5
+00W_500H.jpg
stationName=QuickMix
songStationName=Major Tom Radio
pRet=1
pRetStr=Everything is fine :)
wRet=1
wRetStr=Everything's fine :)
songDuration=214
songPlayed=214
rating=0
detailUrl=http://www.pandora.com/bastille/pompeii-remixes/pompeii?dc=2
+32&ad=1:23:1:47805::0:msn:0:0:581:307:IN:18167:0:0:0:0:6:0
stationCount=74
station0=28 Days Radio
station1=And so on...

[download]

In reply to RFC: pianobar event example by ulterior_modem

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.