As soon as $s contains a "true" value, your loop will not terminate because the loop condition will always be true.

trizen's suggestion doesn't do that because chomp returns the number of characters removed, which will be zero when end-of-file is reached on STDIN - but it won't terminate on a blank line, since that still has a newline character. Personally, I might have written it like this:

while(<STDIN>) { chomp; $s.=$_; print "$s\n"; }

However, putting the reading of STDIN in the condition of the while makes me suspect that you want to terminate the loop when an empty line is input. If that's what you want, here's one way to do that:

while(<STDIN>) { chomp; last unless length; $s.=$_; print "$s\n"; }

Also, often, using <> instead of <STDIN> can be helpful because it gives you the power of Perl's magic ARGV (see I/O Operators). Unless you explicitly want to read from STDIN, I'd suggest using <>.


In reply to Re: Noob's question by Anonymous Monk
in thread Noob's question by gonny95

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.