Hi

you've a little Copy&Paste bug in your code. After pointing out that placeholder variables are the better solution (++) you missed changing the timestamp variables to strings without single quotation mark which is only necessary when you do string interpolation while generating valid SQL statements:

my @date1 = ('2013-08-01 00:00:00.000','2013-08-02 00:00:00.000');

[download]

I would go one step further for clarification of the intention of the code. Why not doing the following to emphasis on the fact that the author wants to interate over several time intervals:

my @intervals = (
    ['2013-08-01 00:00:00.000', '2013-08-02 00:00:00.000'],
    ['2013-08-02 00:00:00.000', '2013-08-03 00:00:00.000'],
);
...
foreach my $interval (@intervals) {
    $sth->execute(@$interval);
...
}

[download]

And as soon as you look at the intervals and at the SQL statement you see that AllPaoTeam made a litte mistake concerning interval boundaries IMHO. Make one end of the interval inclusive the other end exclusive:

WHERE master.dbo.fn_sqlvarbasetostr(AuditChrt_TimeStamp) >= ?    
AND master.dbo.fn_sqlvarbasetostr(AuditChrt_TimeStamp) < ?

[download]

otherwise you would count entries on 2013-08-02 00:00:00.000 twice (except for being intended).

Regards
McA

In reply to Re^2: SQL query using elements from array by McA
in thread SQL query using elements from array by AllPaoTeam

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.