Hi,
With a desire to write elegant/optimal code in perl,i want to know any suggestions the monks might have to spare me.
A customer gave me a word document with country (duplicates due to multiple commitees per country)names.
I need to create a drop down in html showing country names.
Hence my trivial code below to read a list of duplicate country names , identify unique names and write them to a file in alphabetical order. Basic stuff.
#!/usr/bin/perl
use strict;
my ($key,$name,%countries);
open (my $fh1,"<","files/country_listv1.txt") or die $!;
while(<$fh1>){
if (!exists $countries{$_}){
$countries{$_} = '1';
}
}
open (my $fh2,">","files/country_listv2.txt") or die $!;
foreach $key (sort keys %countries){
print $fh2 $key;
}
close($fh1,$fh2);
update
I still have one issue the comma character appears as €TM. I suspect its a encoding issue of my text file. I am using textedit on a mac which doesnt seem to have a save as UTF8 option.strange. Im just updating this query than create a new one.
Im going to try some options but please tell me which is the best way out, as this problem seems a generic one.
use utf8 encoding in my perl script.
recreate the text file in vim
any other options ?
Do we have some perl code checker available for us to validate scripts / modules ?
Thanks
Do not wait to strike when the iron is hot! Make it hot by striking - WB Yeats
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.