My review: the source code is really bad. Use strict, warnings, use File::Spec, File::Temp and other standard library modules. Don't use two-argument form of open, don't use bareword filehandles, etc.Global symbol "@ReadConfigValues" requires explicit package name at pr +oject2 line 23. Global symbol "@ReadConfigValues" requires explicit package name at pr +oject2 line 29. Global symbol "$i" requires explicit package name at project2 line 47. Global symbol "$i" requires explicit package name at project2 line 47. Global symbol "@ReadConfigValues" requires explicit package name at pr +oject2 line 47. Global symbol "$i" requires explicit package name at project2 line 47. Global symbol "@ServiceList" requires explicit package name at project +2 line 48. Global symbol "@ReadConfigValues" requires explicit package name at pr +oject2 line 48. Global symbol "$i" requires explicit package name at project2 line 48. Global symbol "@LogFileList" requires explicit package name at project +2 line 49. Global symbol "@ReadConfigValues" requires explicit package name at pr +oject2 line 49. Global symbol "$i" requires explicit package name at project2 line 49. Global symbol "@TempLogFileList" requires explicit package name at pro +ject2 line 55. Global symbol "@TempServiceList" requires explicit package name at pro +ject2 line 56. Global symbol "@TempLogFileList" requires explicit package name at pro +ject2 line 58. Global symbol "@LogFileList" requires explicit package name at project +2 line 59. Global symbol "@TempLogFileList" requires explicit package name at pro +ject2 line 59. Global symbol "$i" requires explicit package name at project2 line 60. Global symbol "$i" requires explicit package name at project2 line 60. Global symbol "@LogFileList" requires explicit package name at project +2 line 60. Global symbol "$i" requires explicit package name at project2 line 60. Global symbol "@LogFileList" requires explicit package name at project +2 line 61. Global symbol "$i" requires explicit package name at project2 line 61. Global symbol "@LogFileList" requires explicit package name at project +2 line 61. Global symbol "$i" requires explicit package name at project2 line 61. Global symbol "@ServiceList" requires explicit package name at project +2 line 63. Global symbol "@TempServiceList" requires explicit package name at pro +ject2 line 66. Global symbol "@ServiceList" requires explicit package name at project +2 line 67. Global symbol "@TempServiceList" requires explicit package name at pro +ject2 line 67. Global symbol "$i" requires explicit package name at project2 line 68. Global symbol "$i" requires explicit package name at project2 line 68. Global symbol "@ServiceList" requires explicit package name at project +2 line 68. Global symbol "$i" requires explicit package name at project2 line 68. Global symbol "@ServiceList" requires explicit package name at project +2 line 69. Global symbol "$i" requires explicit package name at project2 line 69. Global symbol "@ServiceList" requires explicit package name at project +2 line 69. Global symbol "$i" requires explicit package name at project2 line 69. Global symbol "@ServiceList" requires explicit package name at project +2 line 75. Global symbol "@LogFileList" requires explicit package name at project +2 line 75. Global symbol "@ServiceList" requires explicit package name at project +2 line 76. Global symbol "$ThisFile" requires explicit package name at project2 l +ine 87. Global symbol "$ThisFile" requires explicit package name at project2 l +ine 88. Global symbol "$ThisService" requires explicit package name at project +2 line 89. Global symbol "$ThisFile" requires explicit package name at project2 l +ine 89. Global symbol "$ThisService" requires explicit package name at project +2 line 90. Global symbol "$ThisService" requires explicit package name at project +2 line 90. Global symbol "@AllServices" requires explicit package name at project +2 line 91. Global symbol "$ThisService" requires explicit package name at project +2 line 91. Global symbol "@ServiceList" requires explicit package name at project +2 line 98. Global symbol "@ServiceList" requires explicit package name at project +2 line 98. Global symbol "@ServiceList" requires explicit package name at project +2 line 100. Global symbol "@AllServices" requires explicit package name at project +2 line 100. Global symbol "@LogFileList" requires explicit package name at project +2 line 101. Global symbol "@LogFileList" requires explicit package name at project +2 line 102. Global symbol "@ServiceList" requires explicit package name at project +2 line 102. Global symbol "$LogFile" requires explicit package name at project2 li +ne 131. Global symbol "@LogFileList" requires explicit package name at project +2 line 131. Global symbol "$FileText" requires explicit package name at project2 l +ine 134. Global symbol "$FileText" requires explicit package name at project2 l +ine 135. Global symbol "$LogFile" requires explicit package name at project2 li +ne 135. Global symbol "$FilterText" requires explicit package name at project2 + line 137. Global symbol "$FilterText" requires explicit package name at project2 + line 139. Global symbol "$LogFile" requires explicit package name at project2 li +ne 139. Global symbol "$Command" requires explicit package name at project2 li +ne 141. Global symbol "$FileText" requires explicit package name at project2 l +ine 141. Global symbol "$FilterText" requires explicit package name at project2 + line 141. Global symbol "$LogFile" requires explicit package name at project2 li +ne 141. Global symbol "$Command" requires explicit package name at project2 li +ne 142. Global symbol "$Command" requires explicit package name at project2 li +ne 143. Global symbol "$LogFile" requires explicit package name at project2 li +ne 150. Global symbol "@LogFileList" requires explicit package name at project +2 line 150. Global symbol "$FileText" requires explicit package name at project2 l +ine 152. Global symbol "$FileText" requires explicit package name at project2 l +ine 153. Global symbol "$LogFile" requires explicit package name at project2 li +ne 153. Global symbol "$FilterText" requires explicit package name at project2 + line 155. Global symbol "$FilterText" requires explicit package name at project2 + line 156. Global symbol "$LogFile" requires explicit package name at project2 li +ne 156. Global symbol "$Command" requires explicit package name at project2 li +ne 159. Global symbol "$FileText" requires explicit package name at project2 l +ine 159. Global symbol "$FilterText" requires explicit package name at project2 + line 159. Global symbol "$LogFile" requires explicit package name at project2 li +ne 159. Global symbol "$Command" requires explicit package name at project2 li +ne 160. Global symbol "$Command" requires explicit package name at project2 li +ne 161. Execution of project2 aborted due to compilation errors.
In reply to Re: Perl - Source code review
by Anonymous Monk
in thread Perl - Source code review
by bheemamahesh
| For: | Use: | ||
| & | & | ||
| < | < | ||
| > | > | ||
| [ | [ | ||
| ] | ] |