Hi,

to emphasis the two aspects of the function you could do a grep (removing totally empty list elements) with a map (removing leading and trailing whitespace).

UPDATE: Taste is hardly debatable, but performance often not:

use strict;
use warnings;
use Data::Dumper;
use Benchmark qw(cmpthese);

# Returns non-empty strings with leading and trailing spaces removed.
sub mytrim_nonempties {
    grep { $_ ne '' } map { s/^\s+//; s/\s+$//; $_ } @_;
}

sub trim_nonempties
{
   ## no critic (ProhibitMutatingListFunctions)
   grep { !/^\s*$/ && s/^\s*|\s*$//g } @_;
   ## use critic
}


my @x = ( ' hello ', "\thello again\t", '', " ", " \t", 'jock', "\t ab
+c", "def \t " );

cmpthese(1000000, {
    'myfunc' => sub {
        my @y = mytrim_nonempties(@x);
    },
    'yourfunc' => sub {
        my @y = trim_nonempties(@x);
    },
});

[download]

McA

In reply to Re: Code review: function to trim whitespace from all items in a list by McA
in thread Code review: function to trim whitespace from all items in a list by eyepopslikeamosquito

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.