The warning about uninitialized value is because in line 6 of the code you posted you set $name to contain nothing, and then in line 8 of the code you posted, you call printname($name). As the printname function executes, it attempts to print "Hello $name\n", where $name is empty (or undef), and this throws a warning.

Later when you call printname("John"), it actually works, because the parameter you pass in is not empty; it contains "John".

There are other issues, such as calling printname from your package main without your printname.pm module actually exporting the subroutine. But apparently your actual usage is not exactly as described, because you didn't mention that error. If you are seeing that error but simply not mentioning it, you should look at Exporter for solutions.

Additionally, you really should be using lexical variables in your subroutine that are scoped to the subroutine itself, not to the entire file: my ($name) = @_; would be a good start.


Dave

In reply to Re: Custom Module question by davido
in thread Custom Module question by imfaus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.