Personally I prefer the Attack->heavy approach over Attack->new("heavy"). Why? Because when (not "if"!) you mistype it as "haevy", then Perl will automatically generate an error message for you. You don't need to write that logic to check the string is valid; Perl will for you.

To an extent I agree with hippo's answer, that it's nice for constructors to be called new, but I don't think that warrants throwing out the whole approach. Instead you could just name the method Attack->new_heavy. This is perfectly clear, and similar to things like new_from_file or new_from_xml you see all the time.

toby döt ink

In reply to Re: Convenient Constructors - a Moo question by tobyink
in thread Convenient Constructors - a Moo question by blindluke

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.