I think user would expect single mouse click, not only motion, should produce a paint stroke. Plus, not nice that with pointer just above grid line, an item from row below is changed (do bounding boxes of characters overlap slightly, vertically?).

With mouse button pressed, "Motion" event targets same "current" item, but X-Y coordinates are updated continuously. In fact, knowing these X-Y, we can ignore what's "current", fix all of the above and write it simpler:

# ...
$canvas-> Tk::bind( '<B1-Motion>', [ \&set_coord, Ev('x'), Ev('y') ]);
$canvas-> Tk::bind( '<Button-1>', [ \&set_coord, Ev('x'), Ev('y') ]);
$canvas-> Tk::bind( '<Enter>', [ configure => '-cursor', 'crosshair' ]
+);
# ...

sub set_coord {
    my ( $canv, $x, $y ) = @_;
    
    my $r = int( $y / $tile_h );
    my $c = int( $x / $tile_w );
    my ( $item ) = $canv-> find( withtag => "$r-$c", );
    $canv-> itemconfigure( $item, -text => $default_char );
}

[download]

Further nitpicks :) : the $default_char = ' '; appears to belong to initialization section, but does nothing. Could be moved somewhere further. + Some would argue that widgets' tab-order (i.e. I press Tab and focus moves from left to right instead of ...in unexpected ways) is important.

In reply to Re: Tk ASCII Draw on Canvas by vr
in thread Tk ASCII Draw on Canvas by Discipulus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.