Athanasius, your explanation was very helpful. I will tune-up the loop construct as you have suggested.

As far as the custom sub goes (findfiles) there is not any files that go with it. I am the original developer of this code with the help of a Senior Developer. The section of code in question was his suggestion. He probably mentioned that I need to define findfiles, but those directions were not in my notes, nor my recollection. He is on vacation now.

I was researching File::Find and came up with this piece of code. It is a little cryptic and I feel it is missing something. Monks, can you please take a look and help me with the details? I noted the new code with "New piece of code".

use strict;
use warnings;
use diagnostics;
use autodie;
use File::Copy::Recursive qw( rcopy );                          
use File::Path qw( mkpath remove_tree ); 
use File::Glob qw( :globally );
use File::Find;
use File::Spec;
use Getopt::Long;                   
use Pod::Usage;                   
use POSIX qw(strftime);
use File::Spec::Functions;

#Set command line arguments
my ($website, $old_ip, $new_ip) = @ARGV;
 
#Set vars
my $TIMESTAMP      = strftime("%Y%m%d%H%M", localtime);               
+                          
#my $volume         = 'C:/';                                          
+                              
my $SourceDir      = File::Spec->catfile((qw(C: Users st2641 Desktop S
+ource_dir)));                 
my $destinationDir = File::Spec->catfile(qw(C: Users st2641 Desktop), 
+$website);                      
my $ARCHIVE        = File::Spec->catfile(qw(C: Users st2641 Desktop), 
+join('_', $website, $old_ip, $TIMESTAMP));
my @WEBSITES       = qw( three five calnet-test );
my $file;
my @errors;
my @file_list;


sub DirCompare{
  my ( %old_list, %new_list, @diffs);
 
  ###for my $file ($ARCHIVE)  {
  ###$old_list{$file} = 1;
  ###}
  #////New piece of code
  for my $file ( find ( sub { $new_list { $file } = 1 }, $SourceDir ) 
+); 
  
  for my $file (keys %old_list) {
    if ( !exists $new_list{$file} ) {
      push @diffs, "Old file not in new: $file";
    }
  }
  for my $file (sort keys %new_list) {
    if ( !defined $old_list{$file} ) {
      push @diffs, "Old file not in new: $file";
    }
  }
  if (@diffs) {
    my $msg = sprintf "WARNING: %s\n", join "\nWARNING: ", @errors;
    check_ok( $msg );
  }
  return;
}
 
$file (find( sub {$new_list{$file} = 1}, $SourceDir ) );

[download]

In reply to Re^2: Comparing files in directory by smturner1
in thread Comparing files in directory by smturner1

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.