If you change line 21 from this:

open my $in_fh, '<', $_;

[download]

.. to this...

open my $in_fh, '<', $_ or die $!;

[download]

... you may see an error message telling you that a file failed to open. If that's the case, you would have to decide whether it's worth continuing on to the next file instead, or whether you should terminate immediately.

Next, you should test @lines to see how many elements it holds. If it's empty, it is possible you were reading an empty file. If that's the case, you would probably want to skip further processing on the file. And again you would have to make the decision whether to log a warning or die.

Update: toolic correctly pointed out to me that the OP is using autodie, so my suggestion for "or die $!" is superfluous. Those who mentioned that readdir returns a list of everything including such non-files as ./ and ../ are correct.


Dave

In reply to Re: Error "Use of uninitialized value $lines[0] in substitution (s///) at " with below Code by davido
in thread Error "Use of uninitialized value $lines[0] in substitution (s///) at " with below Code by Eric_h

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.