Hello batrams,

On each iteration you push the contents of the next array onto @newArr, but this array is never cleared, so by the end of the while loop you are greping through every element in every array within %HoA! It’s not surprising that this is very slow!

But I don’t understand why you need to construct the array at all. The following should be all you need:

#! perl
use strict;
use warnings;

my %HoA =
(
    no1  => [ 'c', 'd'      ],
    yes1 => [ 'X'           ],
    no2  => [ 'e', 'e', 'f' ],
    yes2 => [ 'a', 'X', 'b' ],
);

my $a = 'X';

for my $key (keys %HoA)
{
    print "Element '$a' found, key = $key\n" if grep {$_ eq $a} @{ $Ho
+A{$key} };
}

[download]

Output:

13:00 >perl 1095_SoPW.pl
Element 'X' found, key = yes2
Element 'X' found, key = yes1

13:12 >

[download]

If this is still too slow, you can replace the call to grep with something more idiomatic: see How can I tell whether a certain element is contained in a list or array?, especially the first function in the core module List::Util.

Hope that helps,

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

In reply to Re: Have hash of arrays. Want to test if variable is a member of any of the arrays by Athanasius
in thread Have hash of arrays. Want to test if variable is a member of any of the arrays by batrams

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.