I've refactored your code to use strictures and get rid of various global variables. The window variable and file path get passed into the OK dialog as closures instead of using global variables. The code now works as I understand you would like.

use strict; use warnings; use Tk; my @files = 1 .. 10; for my $file (@files){ { my $mw = MainWindow->new; $mw->geometry("400x120"); $mw->title("CI Generation"); #-----------------Frames-----------------------# my $main_frame = $mw->Frame()->pack( -side => 'top', - fill => 'x +' ); my $top_frame = $mw->Frame( -background => 'light green' )->pack( -side => 'to +p', -fill => 'x' ); my $left_frame = $mw->Frame( -background => 'white' )->pack( -side => 'top', -f +ill => 'x' ); $top_frame->Label( -text => "Copy generated *.[ch] files to host repository", )->pack( -side => 'top' ); $left_frame->Label( -text => "Enter host repository path:", -background => 'yellow' )->pack( -side => 'top', -fill => 'x' ); my $pathEntry = "path/$file"; my $entry = $left_frame->Entry( -textvariable => \$pathEntry, -width => 50)->pack( -side => 'top', -fill => 'x' ); my $buttons = $left_frame->Frame()->pack(-side => 'bottom', -fill=>'both', - +expand=> 0); my $executeButton= $buttons->Button( -text => "Continue", -command => sub{okbutton($mw, $pathEntry)}, -width => 20, -height => 2, -underline => 11 )->pack(-side => "left"); my $exitButton = $buttons->Button( -text => "Cancel", -command => sub { exit 1; }, -width => 20, -height => 2, -underline => 11 )->pack(-side => "right"); MainLoop; } } sub okbutton{ my ($mw, $pathEntry) = @_; print $pathEntry; if (!$pathEntry) { $mw->messageBox( -icon=>'error', -title=>'Error on Repository Path', -message=>"Error: Repository path should not be empty." ); return ""; } if ($pathEntry !~ /[1245679]/) { $mw->messageBox( -icon=>'error', -title=>'Error on Repository Path', -message=>"Error: Repository path can not include 3, 8 or +0." ); return ""; } $mw->destroy if Tk::Exists($mw); }

Note that I've altered the OK dialog file tests a little to make the code testable without needing a file system.

Optimising for fewest key strokes only makes sense transmitting to Pluto or beyond

In reply to Re: perl tk get user input by GrandFather
in thread perl tk get user input by vinoth.ree

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.