This does not do what you want, what happens if mkpasswd() yields illegal characters for a second time in a row?:

my $password = mkpasswd();

if ( $password =~ m/\"|\'/ ) {
    $password = mkpasswd();
}

[download]

consider this instead:

my $password;
do {
  # theoretically it can get stuck in an infinite loop here...
  $password = mkpasswd();
} while( $password =~ m/\"|\'/ );

[download]

As for deleting user dirs, you really should check rmtree's return code, see File::Path . Also check each system()'s return code and handle failures accordingly. You don't do this.

For a discussion about using system() and alternatives see Calling External Commands More Safely

In reply to Re: Script for SFTP users not deleting accounts automatically by bliako
in thread Script for SFTP users not deleting accounts automatically by C18ANT

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.