1. There shall NEVER be an else after a return/exit/croak/die! NEVER!
  2. You call wget from a composed string. If the $url has " in there (or worse, a ; followed by a command as haukex poited out in Re: wget not working from perl), quotation as you use it might fail:
    my $COMMAND = "wget -q -O $FILENAME $URL"; print `$COMMAND`;

    --->

    open my $sh, "-|", "wget", "-q", "-O", $FILENAME, $URL; print <$sh>; close $sh;

    is much safer.

  3. Why do you use all those capitalized variable names?
  4. Why use a shell escape anyway?
    use LWP::Simple; is_success (getprint ($URL)) or warn "Fetch failed";

Enjoy, Have FUN! H.Merijn

In reply to Re: wget not working from perl by Tux
in thread wget not working from perl by harangzsolt33

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.