I don't use puppet either. However, I do not see the point in using regex for this:

/usr/bin/perl -ni -e 'print unless /^\\Q${line}\\E\$/' '${file}'

where it appears that you are just wanting an exact match on the entire line. While quotemeta will get you so far, remember that you are substituting ${line} in at the shell level, so any regex-terminating characters within that variable will also have to be escaped somehow. Much better to use an exact match I would have thought.

Similarly, you could specify the line to remove in an env var, thus avoiding one layer of escaping.

Without puppet and just using STDIN for clarity, here is a demo of both:

$ export LINE=bar $ echo -e "foo\nbar\nbaz" | perl -lne 'print unless $_ eq $ENV{LINE}'

You'll still need to sanitize/escape/quote your equivalent of "bar" when setting the environment variable but that should be a simpler task.


In reply to Re: One liner: remove ssh keys with quotemeta by hippo
in thread One liner: remove ssh keys with quotemeta by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.