That's a lot of code.

Well, as for suggestions, use perltidy. Hopefully you see why.

    if (!defined $match) {
        print "$ip: ERROR_1\n";
        print LOG "$ip: ERROR_1\n";
        return;
    }
...
    if (!defined $match) {
        print "$ip: ERROR_13\n";
        print LOG "$ip: ERROR_13\n";
        return;    
        }
...
sub get_inventory {
    my ($ip, $t) = (@_);
    if (!$t->cmd('terminal length 0')) {
        print "$ip: Error changing terminal length\n";
        print LOG "$ip: Error changing terminal length\n";
        }
        my @show_run = $t->cmd('show run | inc hostname');
        ...

[download]
Did you assemble this stuff from different sources?

In reply to Re: Could you suggest improvements to my Cisco network device audit script? by Anonymous Monk
in thread Could you suggest improvements to my Cisco network device audit script? by monkerz57

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.