There is a mixture of coding styles there. Some good, some bad:

In many places you test if (!defined $match) { after using (the possibly undefined) $match in earlier tests. Check that the order of your tests makes sense.

An if that ends in a return doesn't need an else. Instead:

if (...) { ... return; } ... # "else" stuff

In many places you print to stdout and to a log file. Why not have a log sub that prints to both?

Don't put the loop body on the same line as the loop statement. The loop construct as a statement modifier is ok though:

while (<$channel>) {push @output, $_} #becomes push @output, $_ while <$channel>; #although my @output = <$channel>; #is even better
for my $i (@show_inventory) { my $inv_line1 = shift @show_inventory; my $inv_line2 = shift @show_inventory;

is plain wrong. Maybe you meant:

while (@show_inventory) { my $inv_line1 = shift @show_inventory; my $inv_line2 = shift @show_inventory;
Perl is the programming world's equivalent of English

In reply to Re: Could you suggest improvements to my Cisco network device audit script? by GrandFather
in thread Could you suggest improvements to my Cisco network device audit script? by monkerz57

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.