monkerz57:

I notice a good few variations of:

if (condition) {
   print "Some string\n";
   print LOG "Some string\n";
   return;
}

[download]

It's frequent enough that I'd do something about it to simplify things a bit. I think I'd first create a subroutine like:

sub LOGIT {
   my @args = @_;
   print @args, "\n";
   print LOG @args, "\n";
}

[download]

Then I'd probably use it like so:

condition or return LOGIT("some string");

[download]

Some variation of that might help you make the code a little easier on the eyes.

...roboticus

When your only tool is a hammer, all problems look like your thumb.

In reply to Re: Could you suggest improvements to my Cisco network device audit script? by roboticus
in thread Could you suggest improvements to my Cisco network device audit script? by monkerz57

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.