You only need to prepare the statements once

#!perl use strict; use Text::CSV; use DBD::Oracle; my $csv = Text::CSV->new ( { binary => 1 } ) or die "Cannot use CSV: ".Text::CSV->error_diag (); my $dbh = dbh(); # connect my $SQL1 = "INSERT INTO TAB1 (sample_date, server, first, n1, n2) VALUES (?,?,?,?,?)"; my $sth1 = $dbh->prepare($SQL1); my $SQL2 = "INSERT INTO STATUS (sample_date,server,csv_file,row_count, +status) VALUES (sysdate,?,?,?,?)"; my $sth2 = $dbh->prepare($SQL2); my @csvFile = ('1.csv','2.csv','3.csv'); for my $file (@csvFile){ insertRecords($file); } $dbh->disconnect; sub insertRecords { my $file = shift; print "Working under $file\n"; open my $fh,'<',$file or die "$file : $!"; my $status = "SUCCESS"; my $server; my $rc = 0; while (my $row = $csv->getline ($fh)){ ++$rc; $server = $row->[1]; print join ",",@$row[0..4],"\n"; if ( $sth1->execute(@$row[0..4]) ){ # ok } else { $status = "FAILURE"; last; } }; if ($status eq 'FAILURE'){ $dbh->rollback; $rc = 0; print "ERROR - Rolled back $file\n"; } $sth2->execute($server,$file,$rc,$status); $dbh->commit; close $fh; } # connect sub dbh { my $host = "localhost"; my $sid = 'xe'; my $user = ''; my $pwd = ''; my $dsn = "dbi:Oracle:host=$host;sid=$sid"; my $dbh = DBI->connect($dsn, $user, $pwd, { AutoCommit => 0, }) or die "$!"; return $dbh }
poj

In reply to Re^3: Perl oracle insert error handling by poj
in thread Perl oracle insert error handling by homer4all

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.