comment on

You need to organize your code, box up everything into subroutines, Every loop, every every giant if/else block, every system call, every level of nested nesting.

And name your variables good, gets easier once you start coping with scoping, Re^3: A Beginner Needs Homework help

So in the end you have your final program something like this, cgi101

Main( @ARGV );
exit( 0 );
sub Main {
    my $config = "${HOME}/config";
    my $cgi = CGI->new;
    my $type = $cgi->param('type');
    $type eq 'html' and return HtmlPage( $cgi, $config );
    $type eq 'xls' and return XlsPage( $cgi, $config );
    $type eq 'csv' and return CsvPage( $cgi, $config );
    return HtmlPage( $cgi, $config ); # default
}


sub XlsPage {
  my( $cgi ) = @_;
  MakeXls( $cgi , '/path/to/foo.xls' );
  SendFile(
      $cgi,
      '/path/to/foo.xls',
      'foo-downloaded.xls',
      'application/vnd.ms-excel',
  );
}


sub XlsPage {
  my( $cgi ) = @_;
  MakeCsv( $cgi , '/path/to/foo.csv' );
  SendFile(
    $cgi,
    '/path/to/foo.csv',
    'foo-downloaded.csv',
    'text/csv',
  );
}
[download]

Use $cgi->header for headers, like to send files to be downloaded by users

sub SendFile {
    my $cgi = shift || CGI->new;
    my $file = shift or die "What file to send?!";
    my $filename = shift || 'filename';
    my $mimetype = shift || 'application/octet-stream';
    open my($fh),'<:raw', $file or die "Can't read ($file): $!\n$^E\n 
+";
    binmode STDOUT; 
    print $cgi->header(
        -type => $mimetype,
        -attachment => $filename,
        -Content_length => -s $fh,
    );
#     print $_ while readline $fh;
    local $/; ## slurp mode
    print readline($fh);
    close $fh;
    close STDOUT;
}
[download]

So starting with the program you have, first step, create the outline, replace blocks with subroutine calls, use your own good names

#!/usr/bin/perl
require 'ConvertDates.pl';

use DBI;
use Date::Manip ;
use CGI;

my $cgi = CGI->new;
# $parms = CGI->new;
#parse parameters

my $start_date = $parms->param("sd");
my $end_date = $parms->param("ed");
my $separator= $parms->param("sep");
my $HOME="/export/home/pmdss";
my $CONFIG="${HOME}/config";

$row=0;
$rows=0;
$NumOfRts=1500;
$CntOfRts=0;

# print "Content-type: text/plain\n\n" ; 

# chomp($ds_mach=`cat ${CONFIG}/BigIron`);
# chomp($dr_mach=`cat ${CONFIG}/BigIronDR`);
my $ds_mach =  CatConfig( "${CONFIG}/BigIron" );
my $dr_mach =  CatConfig( "${CONFIG}/BigIronDR" );

my $id = PingerIdOrDeath( $ds_mach , $dr_mach );
# system("/usr/sbin/ping $ds_mach >/dev/null 2>/dev/null");
# if ( ($? >> 8) eq 0 ) {
#         $id = "pmdss\@$ds_mach";
# }
# else {
#         system("/usr/sbin/ping $dr_mach >/dev/null 2>/dev/null");
#         if ( ($? >> 8) eq 0 ) {
#                 $id = "pmdss\@$dr_mach";
#         }
#         else {
#                 print "A serious error has occurred, please contact 
+production support or try again later...\n" ;
#                 exit 0;
#         }
# }


my $slotsPortsNodes =  sshMeSomeSlotsPortsNodes( $id, $start_date, $en
+d_date );
# $cmd = "ssh $id '. ~/q; \$Q/AgnEthernetList3-1.X -s $start_date -e $
+end_date' 2>/dev/null |";
# #print "$cmd\n";
# open (input , $cmd);
# while ($INPUT_LINE = <input>) {
#         chomp($INPUT_LINE);
#         ($dat{l_node}, $dat{l_slot}, $dat{l_ifNum}, $dat{r_node}, $d
+at{r_slot}, $dat{r_line}, $dat{r_port}, $dat{kbps},
#         $dat{subnetwork}, $dat{subnetwork2}, $dat{r_domain_id}, $dat
+{icore_domid}, $dat{cust_port},
#         $dat{track_port},$dat{vlan_stacking_inv}, $dat{cos_level}, $
+dat{equip_type_id}) = split(/  /, $INPUT_LINE);


#         $KEY = $dat{l_node} . "." . $dat{l_slot} . "." .  $dat{l_ifN
+um};

#         $key2 = int($CntOfRts++/$NumOfRts);
#         ($nspString{$key2} = $nspString{$key2} . ":") if ($nspString
+{$key2} ne "");
#         $nspString{$key2} = $nspString{$key2} . "$dat{l_node},$dat{l
+_slot},$dat{l_ifNum}";

#         $arraykey{$KEY} = $KEY;
#         $r_node{$KEY} = $dat{r_node};
#         $r_slot{$KEY} = $dat{r_slot};
#         $r_port{$KEY} = $dat{r_port};
#         $kbps{$KEY} = $dat{kbps};
#         $subnetwork{$KEY} = $dat{subnetwork};
#         $subnetwork2{$KEY} = $dat{subnetwork2};
#         $r_domain_id{$KEY} = $dat{r_domain_id};
#         ($r_domain_id{$KEY} = $dat{icore_domid}) if ($r_domain_id{$K
+EY} eq "");
#         $cust_port{$KEY} = $dat{cust_port};
#         $track_port{$KEY} = $dat{track_port};
#         $vlan_stacking_inv{$KEY} = $dat{vlan_stacking_inv};
#         $cos_level{$KEY} = $dat{cos_level};
#         $rows = $rows + 1;
# }
# close (input);


# foreach $key (sort keys nspString) {
#         $cmd = "ssh $id '. ~/q; \$Q/AgnEthernetList3-2.X -nsp $nspSt
+ring{$key}' 2>/dev/null |";
#         #print "$cmd\n";
#         open (input , $cmd);
#         while ($INPUT_LINE = <input>) {
#                 chomp($INPUT_LINE);
#                 ($dat2{pvcs}, $dat2{lcir}, $dat2{rcir}, $rswitch, $r
+slot, $rport) = split(/  /, $INPUT_LINE);
#                 $KEY = $rswitch . "." . $rslot . "." .  $rport;

#                 $pvcs{$KEY} = $dat2{pvcs};
#                 $lcir{$KEY} = $dat2{lcir};
#                 $rcir{$KEY} = $dat2{rcir};
#         }
#         close (input);
# }

my( $toNetwork, $domain ) =  sshMeSomeObjectIdsDomainNames( $id, $end_
+date );
# $cmd = "ssh $id '. ~/q; \$Q/AgnNniGatewayList4-4.X -date $end_date' 
+2>/dev/null |";
# open (input , $cmd);
# #print "$cmd\n";
# while ($INPUT_LINE = <input>) {
#         chomp($INPUT_LINE);
#         ($dat{object_id}, $dat{domain}, $dat{long_name}) = split(/  
+/, $INPUT_LINE);

#         $toNetwork{$dat{object_id}} = $dat{long_name};
#         $domain{$dat{object_id}} = $dat{domain};
# }
# close (input);


if ($rows > 0) {
    print CsvSlotsHeader( $slotsPortsNodes );

#         print "l_node\t" .
#                 "l_slot\t" .
#                 "l_port\t" .
#                 "r_node\t" .
#                 "r_slot\t" .
#                 "r_port\t" .
#                 "kbps\t" .
#                 "subnetwork\t" .
#                 "toNetwork\t" .
#                 "pvcs\t" .
#                 "lcir\t" .
#                 "rcir\t" .
#                 "domain\t" .
#                 "track_port\t" .
#                 "vlan_stacking_inv\t" .
#                 "cos_level\t" .
#                 "placeholder";

    print CsvSlotsData( $slotsPortsNodes );
#         foreach $key (keys arraykey) {
#                 ($l_node,$l_slot,$l_ifNum) = split(/\./, $key);

#                 if (substr($l_node,10,3) eq "ME2") {
#                         if ($l_slot >= 10000) {
#                                 if ( substr($l_slot,1,1) eq "0" ) {
#                                         $L_SLOT = substr($l_slot,2,1
+) . "-" . substr($l_slot,4,1) ;
#                                 } else {
#                                         $L_SLOT = substr($l_slot,1,2
+) . "-" . substr($l_slot,4,1) ;
#                                 }
#                         } else {
#                                 $L_SLOT = $l_slot ;
#                         }
#                 } else {
#                         $L_SLOT = $l_slot ;
#                 }
#                 if (TRIM($toNetwork{$r_domain_id{$key}}) ne "") {
#                         $_2Network = $toNetwork{$r_domain_id{$key}};
#                 } else {
#                         $_2Network = $subnetwork2{$key};
#                 }

#                 print "\n" . $l_node . "\t" .
#                         $L_SLOT . "\t" .
#                         $l_ifNum . "\t" .
#                         $r_node{$key} . "\t" .
#                         $r_slot{$key} . "\t" .
#                         $r_port{$key} . "\t" .
#                         $kbps{$key} . "\t" .
#                         $subnetwork{$key} . "\t" .
#                         $_2Network . "\t" .
#                         $pvcs{$key} . "\t" .
#                         $lcir{$key} . "\t" .
#                         $rcir{$key} . "\t" .
#                         $domain{$r_domain_id{$key}} . "\t" .
#                         $track_port{$key} . "\t" .
#                         $vlan_stacking_inv{$key} . "\t" .
#                         $cos_level{$key} . "\t" .
#                         "X";
#         }
} else {
#         print `cat nodata`;
    print NoData();
}

sub TRIM
{
        $A = shift;
        $_ = $A;
        s/^ +//;
        s/ +$//;
        $A = $_;
        return $A;
}
[download]

Well, removing the comments to see how real shape of goals, you've got sub Main101

#!/usr/bin/perl
require 'ConvertDates.pl';

use DBI;
use Date::Manip ;
use CGI;

Main( @ARGV );
exit( 0 );

sub Main {
    my $cgi = CGI->new;

    my $start_date = $parms->param("sd");
    my $end_date = $parms->param("ed");
    my $separator= $parms->param("sep");
    my $HOME="/export/home/pmdss";
    my $CONFIG="${HOME}/config";

    my $ds_mach =  CatConfig( "${CONFIG}/BigIron" );
    my $dr_mach =  CatConfig( "${CONFIG}/BigIronDR" );

    my $id = PingerIdOrDeath( $ds_mach , $dr_mach );

    my $slotsPortsNodes =  sshMeSomeSlotsPortsNodes( $id, $start_date,
+ $end_date );
    my( $toNetwork, $domain ) =  sshMeSomeObjectIdsDomainNames( $id, $
+end_date );

    if ($rows > 0) {
        print CsvSlotsHeader( $slotsPortsNodes );
        print CsvSlotsData( $slotsPortsNodes );
    } else {
        print NoData();
    }
}
__END__
[download]

Then fill in the blanks , notice subroutines take arguments, return values, a hash of hashes, or whatever fits the problem

sub sshMeSomeSlotsPortsNodes {
    my( $id, $start_date, $end_date ) = @_;
    my %network;
    ...
    while ($INPUT_LINE = <input>) {
        my %dat;
        (
            $dat{l_node},      $dat{l_slot},      $dat{l_ifNum},
            $dat{r_node},      $dat{r_slot},      $dat{r_line},
            $dat{r_port},      $dat{kbps},        $dat{subnetwork},
            $dat{subnetwork2}, $dat{r_domain_id}, $dat{icore_domid},
            $dat{cust_port},   $dat{track_port},  $dat{vlan_stacking_i
+nv},
            $dat{cos_level},   $dat{equip_type_id}
        ) = split( /  /, $INPUT_LINE );
        $network{r_node}{$KEY} = $dat{r_node};
        $network{r_slot}{$KEY} = $dat{r_slot};
        $network{r_port}{$KEY} = $dat{r_port};
        ...
        $network{arraykey}{$KEY}=$KEY;
        ...
    }
    return \%network;
}
[download]

Now plug it into the cgi101 sub Main, maybe as sub MakeCsv or something

Every time you make a sub, backup the file you're working on -01.pl -02.pl -03.pl -04.pl...

In reply to Re: Output to a >CSV file by Anonymous Monk
in thread Output to a >CSV file by pragovnj

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.