just want to ask if there is a better way of doing this

That depends on what makes one solution "better" than another and also how representative your sample set is.

use strict;
use warnings;

use Test::More;

my @set = (
    {
        file => '-/yf/-/22211_01_09_2000_XYz.pdf',
        zip  => '22211'
    },
    {
        file => '_/gt/-/02239_04_04_1989_PkW.pdf',
        zip  => '02239'
    },
    {
        file => '-/xy/-/02239_04_04_1989_PkW.pdf',
        zip  => '02239'
    },
);

plan tests => 2 * @set;

for my $datum (@set) {
    is zip_substr ($datum->{file}), $datum->{zip}, "Substr for $datum-
+>{file}";
    is zip_regex  ($datum->{file}), $datum->{zip}, "Regex  for $datum-
+>{file}";
}

sub zip_substr {
    return substr (shift, 7, 5);
}

sub zip_regex {
    my ($zip) = shift =~ m#/(\d{5})_#a;
    return $zip;
}

[download]

In reply to Re: Matching hyphens in file path to extract zip code by hippo
in thread Matching hyphens in file path to extract zip code by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.