You're not storing the j and i values anywhere, so by the time the buttons have been generated, the values will always be the maximum.

I've quickly cleaned up the code. I added the ability to store the values during creation, and use the accurate values when any button is pressed. I updated the subroutine to accept these values as arguments. Most importantly, I added strict and warnings.

use warnings;
use strict;

use Tk;

my $mw = MainWindow->new(-bg=> '#606060', -borderwidth=> 0);
my $size = 40;
my $y = 0;
my $x = 0;
my $h = 3*$size;

my %frames;

for my $j (0..15) {
    my $x = 0;
    my $w = 3*$size;

    for my $i (0..15) {
        $frames{$j}{$i}{j} = $j;
        $frames{$j}{$i}{i} = $i;
        
        $frames{$j}{$i}{button} = $mw->Button(
            -text => ' ', 
            -bg => "#60C8BC", 
            -fg => "#000000", 
            -borderwidth => 1, 
            -anchor => 'w',  
        );

        $frames{$j}{$i}{button}->bind(
            '<Button-1>' => sub { 
                &ToggleBox($frames{$j}{$i}{j}, $frames{$j}{$i}{i}); 
            } 
        );

        $frames{$j}{$i}{button}->place(
            -y=>$y, 
            -x=>$x, 
            -width=>$w, 
            -height=>$h
        );

        $x = $x + $w;
        $w = $size;
        $x = $x+2 if ($i % 5 == 0);
    }
    $y = $y + $h;
    $h = $size;
    $y = $y+2 if ($j % 5 == 0);
}

MainLoop();

sub ToggleBox {
    my ($j, $i) = @_;
    print "$j, $i\n";
}

[download]

In reply to Re: How to pass parameter to a subroutine? by stevieb
in thread How to pass parameter to a subroutine? by jsteng

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.