Walter_T:   To expand on the first point made by haukex, re-declaring a global (e.g., our) variable isn't just unnecessary, it's completely useless. The only thing it will do is to generate a warning message if warnings are enabled – which, IMHO, they should always be.

c:\@Work\Perl\monks>perl -le
"use strict;
 use warnings;
 ;;
 our $x = 'x before loop';
 print qq{before loop: '$x'};
 ;;
 for my $i (1 .. 2) {
   our $x = 'x in loop';
   print qq{in loop: iteration $i: '$x'};
   }
 ;;
 print qq{after loop: '$x'};
"
"our" variable $x redeclared at -e line 1.
        (Did you mean "local" instead of "our"?)
before loop: 'x before loop'
in loop: iteration 1: 'x in loop'
in loop: iteration 2: 'x in loop'
after loop: 'x in loop'
[download]

As the warning message suggests, you may have been thinking of local, which will actually do something in this situation.

c:\@Work\Perl\monks>perl -le
"use strict;
 use warnings;
 ;;
 our $x = 'x before loop';
 print qq{before loop: '$x'};
 ;;
 for my $i (1 .. 2) {
   local $x = 'x in loop';
   print qq{in loop: iteration $i: '$x'};
   }
 ;;
 print qq{after loop: '$x'};
"
before loop: 'x before loop'
in loop: iteration 1: 'x in loop'
in loop: iteration 2: 'x in loop'
after loop: 'x before loop'
[download]

But even when used in this way, globals should, I believe, be avoided. In general, use globals only for good, well-understood reasons.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.