if(defined $cache[$num]) {return $cache[$num];}
if($num < 0) {return 0;}
In Perl, -1 is a valid array index, meaning the last element of the array (-2 is the second-to-last, and so on). Move the if($num < 0) check before the if(defined $cache[$num]) check and your code produces the expected output. Another option would be to use a hash instead of an array as the cache.
A couple more tips:
- Instead of a global, you could define your cache as what is known as a "static" variable in other languages, using state.
- Update: While implementing the cache yourself like that is fine, note that Perl has a module for that, Memoize.
- The &find() style of calling subs is outdated, call your subs without the &.
- The if($num == 0) check isn't necessary if you pre-populate your array with that index.
- You can use Test::More instead of inputting your test cases manually:
use warnings;
use strict;
use feature 'state';
sub find {
state @cache = (1);
my $num = shift;
return 0 if $num < 0;
if ( defined $cache[$num] ) { return $cache[$num] }
$cache[$num] = find($num-1) + find($num-2) + find($num-3);
return $cache[$num];
}
use Test::More tests=>3;
is find(2), 2;
is find(3), 4;
is find(4), 7;
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.