Some quotes were wrong - use warnings would have told you. And an eval was in the wrong place.

EDIT: I shouldn't have posted this in a hurry. Sorry, this does not work.

At least for the given example this works: 

#!/usr/bin/perl

use strict;
use warnings;

#FROM DATABASE TEXT
my $line = "Her house is on 34th Mt. Whitney St. near St. Mt. Helens S
+t.";

#FROM INCOMING FORM INPUTS
my $query = '(St\.\s)(Mt\.\s)(?=Helens)';
my $substitution = 'Mount ${1}';    # USER MAY HAVE ENTERED "$1"

#FOR RETURNED HTML HIGHLIGHT OF CHANGES
my $start = q|<span class="highlight">|;
my $end = "</span>";

return "Regex containing code disallowed." if $query =~ m[\(\?\??\{];
return "Regex containing code disallowed." if $substitution =~ m[\(\?\
+??\{];


my $replace = sub {
  my $evaluate = sub {
      return eval($1);
  };
    my $val = $substitution;
    $val =~ s/(\$\{\d+\})/$evaluate->()/eg;
    $val = "$start$val$end";
    return $val;
};

    eval "\$line =~ s/\$query/$replace->()/eg";

#EXPECTED TEXT AFTER SUBSTITUTION
$line = "Her house is on 34th Mt. Whitney St. near Mount St. Helens St
+.";

[download]

Greetings,
-jo

$gryYup$d0ylprbpriprrYpkJl2xyl~rzg??P~5lp2hyl0p$

In reply to Re: Evaluating user-entered captured groups during Perl substitution by jo37
in thread [SOLVED] Evaluating user-entered captured groups during Perl substitution by Polyglot

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.