Here is your code modified in a few ways:
- There's no need for a main() sub here so I've removed that. The script will run fine without it.
- The @js array is no longer needed so has been removed.
- open now uses the 3-argument form and a lexical filehandle. If it fails the failure message now says why (it could easily be some reason other than the file not being found).
- The results are now stored in a hash since you mentioned you were after a unique list.
- I've had to assume the format of your input data because you never showed that.
- Lots of the places you've used brackets where Perl doesn't require them so those have been removed for clarity.
- I've used postfix versions of unless and for to reduce the number of indented blocks.
The rest of your variable names have been left the same. If I were writing this myself I would lowercase them all but that's purely a stylistic thing.
#!/usr/bin/env perl
use strict;
use warnings;
my %ujs;
my $file = 'access_log.txt';
open my $FH, '<', $file or die "File $file not opened: $!";
while (my $String = <$FH>)
{
next unless $String =~ /([^\/]*\.js)/;
$ujs{$1} = 1;
}
close $FH;
print "$_\n" for sort keys %ujs;
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.