By specifying max_by { $subhash->{$_} }, you're sorting by values, i.e. by the number 1 in the subhashes. That's not what you want. You want to sort directly by $_.

Also, you used max_by even in the second paragraph where you wanted min_by.

After fixing these, it works as you expected: 

#! /usr/bin/perl
use warnings;
use strict;

use List::UtilsBy qw{ min_by max_by };

my %counts = (
    Adam => { "201708" => 1,
              "201703" => 1,
              "201804" => 1,
              "201603" => 1,
              "201705" => 1,
              "201702" => 1,
              "201608" => 1,
              "201704" => 1,
             },
    Sam  => { "201803" => 1,
              "201801" => 1 },
 );

for my $name ( keys %counts ) {
    my $subhash = $counts{$name};
    my $maximal = max_by { $_ } keys %$subhash;
    print "$name, $maximal\n";
}


for my $name ( keys %counts ) {
    my $subhash = $counts{$name};
    my $minimal = min_by { $_ } keys %$subhash;
    print "$name, $minimal\n";
}

[download]

Update:

I also moved the use statement to the top (as it's executed during the compilation phase, anyway) and replaced foreach with its shorter form.

Note that you might use the minmax_by function, too: 

use List::UtilsBy qw{ minmax_by };

for my $name ( keys %counts ) {
    my $subhash = $counts{$name};
    my ($minimal, $maximal) = minmax_by { $_ } keys %$subhash;
    print "$name, $minimal - $maximal\n";
}

[download]

Update 2: But using { $_ } means you can get back to List::Util::min or max, or List::MoreUtils::minmax.

map{substr$_->[0],$_->[1]||0,1}[\*||{},3],[[]],[ref qr-1,-,-1],[{}],[sub{}^*ARGV,3]

In reply to Re: Using List::UtilsBy to print max and min values from a hash of hashes by choroba
in thread Using List::UtilsBy to print max and min values from a hash of hashes by Izzy_Murph

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.