It's close, although your code does not specify the mode to open the file with, and has the if condition outside the while loop, so won't work.

It's also better to use lexical file handles.

Untested modified code is below. I've also done some minor formatting changes, but avoided too many as it can become a matter of aesthetics.

my $fname = "file,fasta"; open my $fh, '<', $fname or die "Cannot open $fname, $!"; while (my $line = <$fh>) { chomp $line; if ($line =~ /CDECGKEFSQGAHLQTHQKVH/) { print "The protein contains the domain"; } else { print "The protein doesn't contain the domain"; } }

See also open and perlvar.


In reply to Re: Finding pattern in a file by swl
in thread Finding pattern in a file by shabird

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.