Interesting .. yet I can see a fairly simple way to restructure this C code, without either of the goto statements ..
something *
alloc_something(void)
{
/* Make two malloc requests. Insure both succeed; return
allocated memory, if any. Three possible logic paths:
1. First malloc fails, and we are done.
2. First malloc succeeds, second malloc fails: free
the first allocated block, and we are done.
3. First and second mallocs succeed, and we are done.
*/
something * ret = malloc(sizeof(something));
/* Did the first request succeed? */
if (ret != NULL) {
ret->another_thing = alloc_another_thing();
/* Did the second request fail? */
if (ret->another_thing == NULL) {
free(ret);
ret = NULL;
}
}
return ret;
}
Alex / talexb / Toronto
Thanks PJ. We owe you so much. Groklaw -- RIP -- 2003 to 2013.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.