Read the entire file into an array rather than opening and reading it inside the loop. Use
grep in scalar context to do the counting.
use strict;
use warnings;
use Data::Dumper;
my $file = \"a\nb\nb\nc\nc\nd\nd\nd\nf\nf\nf"; # In memory 'file'
my @ids = qw( a b c d e f g );
open my $FILE, '<', $file or die "cannot open input file";
my @lines = <$FILE>; # Read entire file into an array
close $FILE;
my %counts;
ID:
foreach my $id (@ids) {
my $count = grep { /$id/ } @lines;
if ($count) {
$counts{$id} = $count;
next ID;
}
warn "$id not found\n";
}
print Dumper \%counts;
OUTPUT:
e not found
g not found
$VAR1 = {
'd' => 3,
'a' => 1,
'c' => 2,
'f' => 3,
'b' => 2
};
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.