The recursion can be simplified, since $level depends on the length of the remaining dimensions in @_.

I also used a "fancy" trick with $cursor as ref to the @coor array.

(EDIT: Of course there is still more room for improvement, it depends if clarity or speed matters)

use strict; use warnings; use Data::Dump qw/pp dd/; use Test::More; sub matrix2 (&@){ my $code = shift; my @coor; my $depth = @_; my $rec; $rec = sub { return $code->(@coor) unless @_; my $level = $depth - @_; my $max = shift; my $cursor = \$coor[$level]; my $arr = [ map { $$cursor = $_; $rec->(@_) } 0 .. $max ]; return $arr; }; $rec->(@_); } my $a_matrix = matrix2 {"<@_>"} 3,2,1; my @classic; for my $x (0..3) { for my $y (0..2) { for my $z (0..1) { $classic[$x][$y][$z] = "<$x $y $z>"; } } } is_deeply($a_matrix,\@classic,"same matrix"); pp \@classic; done_testing;

ok 1 - same matrix [ [ ["<0 0 0>", "<0 0 1>"], ["<0 1 0>", "<0 1 1>"], ["<0 2 0>", "<0 2 1>"], ], [ ["<1 0 0>", "<1 0 1>"], ["<1 1 0>", "<1 1 1>"], ["<1 2 0>", "<1 2 1>"], ], [ ["<2 0 0>", "<2 0 1>"], ["<2 1 0>", "<2 1 1>"], ["<2 2 0>", "<2 2 1>"], ], [ ["<3 0 0>", "<3 0 1>"], ["<3 1 0>", "<3 1 1>"], ["<3 2 0>", "<3 2 1>"], ], ] 1..1

Cheers Rolf
(addicted to the Perl Programming Language :)
Wikisyntax for the Monastery


In reply to Re^2: n-dim array generator by LanX
in thread n-dim array generator by jo37

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.