Whitespace to make things easier to read is *completely* within the eyes of the beholder. Most often, I find *removing* extraneous redundant annoying empty lines improving the readability and maintainability. Also cleaning up is only useful if it matches the style of the surrounding project/script/module(s) after the cleanup. e.g. your cleaned-up code would not fit my standards and my code would not fit yours..

And if you clean up, why not go further?

foreach my $key (grep { !m/\t0$/ } keys %data) {
    my ($chr, $fivep, $threep, $strand) = split m/\t/ => $key;
    say join "\t" => $chr, $fivep, $threep, "-",
        map { $data{$key}{$_} // 0 } @files;
    }

[download]

Less lines more to the point, no need for empty space as each line is clear on itself.

Personally, I'd use Text::CSV_XS with sep => "\t" like this:

use Text::CSV_XS qw( csv );

my @key   = qw( chr fivep threep strand );
my @files = qw( file1.tab file2.tab );

my %c7;
foreach my $file (@files) {
    csv (in     => $file,
         out    => undef,
         sep    => "\t",
         strict => 1,
         on_in  => sub { $c7{join ":" => @{$_[1]}[0..3]}{$file} = $_[1
+][6] }
         );
    }

say join "\t" => @key, @files;
foreach my $key (sort keys %c7) {
    say join "\t" => (split m/:/ => $key), map { $c7{$key}{$_} // 0 } 
+@files;
    }

[download]

Enjoy, Have FUN! H.Merijn

In reply to Re^2: open input files once by Tux
in thread open input files once by v15

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.