Some tips, use Path::Tiny so you don't have to readdir among other things, like this
use Path::Tiny qw/ path /; if( not path( $direct, $yr )->exists ) { path( $direct, $yr )->make_path; } @Old = path( $direct, $yr )->children;

Path::Tiny dies when it can't make_path or children or openread

my $INPUT = path( $inddirect, "company$qtr$yr.idx" )->openr; my $OUTPUT; if( $yr == $startyear && $qtr == $startqtr ) { $OUTPUT = path( $outfil )->openw; ## clobber } else { $OUTPUT = path( $outfil )->opena; ## append }

Also, no need for that giant if/else block, use an array

my @FormGetRes = ( '(10-K )', '(10-K405 )', '(10KSB )', '(10-KSB )', '(10KSB40 )', '(10-KT )', '(10KT405 )', '(10-Q )', '(10QSB )', '(10-QSB )', '(10-QT )', ); @FormGetRes = map { qr{^$_(?!/)}s } @FormGetRes; RELOOP: for my $re ( @FormGetRes ) { if( $form_type =~ $re ) { print OUTPUT "$fullfilename\n"; $count++; last RELOOP; } }

In reply to Re: file not found with OPEN (reafactor) by Anonymous Monk
in thread file not found with OPEN by wrkrbeee

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.