if (shapcs($MyIP , $MyUser , $MyPass , $MyPass2 , $com
+mand1)) {
                    print shapcs($MyIP , $MyUser , $MyPass , $MyPass2 
+, $command1) , "\n" ;
                        }

[download]

That's really bad (sorry for being harsh). You execute the command twice if successful. Consider saving the return code of shapcs() somewhere and THEN check if it was success and print messages appropriately.

Note that shapcs() can fail in a number of ways which ideally must all be checked and appropriate error codes be returned so that the caller knows exactly what went wrong and not just blame "Authentication Failed" which is only 1 of the error cases.

bw, bliako

In reply to Re: problem in loop break by bliako
in thread problem in loop break by GHMON

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.