The first problem that I had with your code was the confusing name, $namecnt. I expected a numeric scalar for that type of name!
I changed that var name to "$names2count" to imply multiple names which will be counted - I assume in a case insensitive manner.
Added: William test case
use strict;
use warnings;
my %name_count;
my $names2cnt='David|Tom|Sam|Will|Dave|William|Thomas';
while (my $line = <DATA>)
{
next unless ($line =~ /\S/); #skip blank lines
my $name = (split (":",$line))[2];
$name_count{$1}++ if $names2cnt =~ /\b($name)\b/i;
}
foreach my $name (sort keys %name_count)
{
print "$name => $name_count{$name}\n";
}
=prints:
Dave => 1
Will => 3 #allows Will and WILL and WiLL spellings
William => 1
=cut
__DATA__
1:NAME:Bob:Bobville:Phone
2:NAME:Dave:Davis:Phone
3:NAME:Will:Willard:Phone
4:NAME:Todd:Toadlane:Phone
5:NAME:WILL:Street:Phone
6:NAME:WiLL:Street2:phone2
7:NAME:WilliaM:xyz:1234
Update: I'm not sure that this \b stuff in the regex is necessary. I put some obvious test cases into the code, but not all possible test cases.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.