Not really bringing new information into play, but just stressing what the others said: YOU ARE DOING IT WRONG!

The way you use SQL is extremely unsafe, and if you don't change that, you will hear somewhere in the near future "I told you so".

# prepare query
my $query = <<"EOSQL";
INSERT INTO closedauctions (
 seller, sellerusername, category, title, bids,
 pounds, description, winningbid, price_per_pound,
 highbidder, buyerusername, month, day, year,
 itemnum, filename)
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
EOSQL

my $sth = $dbh->prepare ($query) or die $sbh->errstr;     

# Execute query
$sth->execute (
    $sellername, $sellerusername, $quota, $category, 1,
    $pounds, $desc, $buyit, $price_per_pound,
    $buyername, $buyerusername, $month, $day, $year,
    $form{ITEM}, $cat
    ) or die $dbh->errstr;

# Done inserting
$sth->finish;

# disconnect from database
$dbh->disconnect;

[download]

Doesn't that look a lot easier to maintain? Besides that this is safer against attacks, it is also portable. e.g. your code would horribly fail if any of the data variable contans a ".

There is a subtle difference with your code: as you force quotation (which is unreliabvle to say the least) in your statement, undefined values will be stored as an empty string in the database (which should generate tons of warnings if you are running under use strict; and use warnings; (but I fear you are not). In this rewritten example, undefined values are stored as NULL.

One last thing to note that would help you find bugs, it to enable showing DBI errors when they happen:

my $dbh = DBI->connect ($dsn, $user, $pass, {
    RaiseError         => 1,
    PrintError         => 1,
    ShowErrorStatement => 1,
    });

[download]

Enjoy, Have FUN! H.Merijn

In reply to Re: Insert into mysql database by Tux
in thread Insert into mysql database by NorCal12

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.