Note that your code does not compile: you're missing a semicolon on the line my @file = @in (and I don't think that line is necessary in the first place, since @file never gets used), and you haven't declared $updateline. And a few comments on other parts of the code: your two open statements are incorrect in that the || operator is not the right thing to use here, see "open" Best Practices for why. Also, your comment "read all file names form dir except names started with dot" doesn't actually describe what the code is doing, so it's confusing, and you should check your opendir for errors as well. And I final nit: you don't need warnings and the -w on the shebang, drop the latter.
In regards to the actual issue: You're reading lines from the IN filehandle into the $file variable. Because of this, $_ does not contain the current line. Your outer for loop is putting each filename in $in, not $file. Also, note that lines read from the input file will still contain the newline character at the end, so you probably should chomp that so that appending something to the line works properly. Taking all that together, changing some variable names, and indenting your code properly:
#!/usr/bin/perl use warnings; use strict; opendir my $dh, 'Master' or die "opendir: $!"; my @files = grep { /\.txt$/ } readdir $dh; closedir $dh; for my $file (@files) { open my $ifh, '<', "Master/$file" or next; open my $ofh, '>', "Update/$file" or die "can't open file Update/$ +file: $!"; while ( my $line = <$ifh> ) { chomp($line); my $updateline = $line . $file; print $ofh $updateline, "\n"; } close $ofh; close $ifh; }
In reply to Re: Adding Filename to the end of each line
by haukex
in thread Adding Filename to the end of each line
by jalopez453
| For: | Use: | ||
| & | & | ||
| < | < | ||
| > | > | ||
| [ | [ | ||
| ] | ] |