my $thispiece = {%$piece};  # create a deep copy

Be aware that {%$piece} creates a shallow copy. It may appear to be deep, but only because $piece is shallow to begin with, i.e., it has only one level. Try your code with a nested structure for $piece: 

Win8 Strawberry 5.8.9.5 (32)  Fri 05/07/2021  7:11:33
C:\@Work\Perl\monks
>perl -Mstrict -Mwarnings

my $Action;

my $piece = { this => { that => { foo => { bar => 123 } } } };

foreach my $other (111 .. 113){
    my $thispiece = {%$piece};  # create a SHALLOW copy
    $thispiece->{theother} = $other;
    push(@{$Action}, $thispiece);
}

use Data::Dumper;
print Dumper($Action);

^Z
$VAR1 = [
          {
            'theother' => 111,
            'this' => {
                        'that' => {
                                    'foo' => {
                                               'bar' => 123
                                             }
                                  }
                      }
          },
          {
            'theother' => 112,
            'this' => $VAR1->[0]{'this'}
          },
          {
            'theother' => 113,
            'this' => $VAR1->[0]{'this'}
          }
        ];

[download]
Of course, if you're only dealing with a shallow structure in $piece to begin with, your code will be fine.

Give a man a fish:  <%-{-{-{-<

In reply to Re^3: Unwanted cloning of array elements by AnomalousMonk
in thread Unwanted cloning of array elements by oakbox

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.