Hi Team,

I have two files; a file with the IP addresses I am looking for (IPS.txt) and a file of 40K firewall rules (rules.txt).

I am trying to use a while to load the file and use an array for the IP addresses. The foreach loop should look up each IP address in the rules file and print each matching line.

It actually works if I search for static text, but as soon as I use my array to plug in the values, it finds nothing. I wonder if it is the formatting of IP addresses or something. I'm stuck.

Here's the script: 

open ( IPS, '<', "GIS_DEV_IPS.txt" ) || die "can't open IPS!";
open ( RULES, '<', "rules.txt" ) || die "can't open file!";

@IPS = <IPS>;
close (IPS);

chomp (@IP);

while($line = <RULES>) {

    foreach  $IP (@IPS) {

        if ($line =~ $IP) { 
            print $line;
        } 
    }
}
exit;

[download]

In reply to Sifting through firewall rules using a script by networkdude

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.