You really need to use strict (use strict;). Consider what happens when the following line invokes the die.
open my $wave, '>', 'Wave' or die "Can't open $wave: $!";
Using three parameter open and error handling is laudatory, but omitting strict and a few other areas of your code could use some TLC. Consider the following light do over:
#!usr/bin/perl
use strict;
use warnings;
open my $wave, '>', 'Wave' or die "Can't open 'Wave': $!
+";
open my $keywords, '<', 'Agents' or die "Can't open 'Agents':
+$!";
open my $search_file, '<', 'Definitions' or die "Can't open 'Definitio
+ns': $!";
my $keyword_or = join '|', map {chomp; qr/\Q$_\E/} <$keywords>;
my $regex = qr|\b($keyword_or)\b|;
while (defined (my $line = <$search_file>)) {
while ($line =~ /$regex/g) {
next if $line =~ /(SCRIPTNAME|DESCRIPTION)/;
print $wave $line;
last;
}
}
Things to note:
- use of strict
- error handling mentions the file name rather than the file function
- Avoid using $_ where a manifest variable can be used instead (c.f. $line)
- use a statement modifier if to skip in the inner loop to make logic flow clearer
- terminate inner loop once the line has been printed to avoid multiple copies
- remove the explicit file close statement. With lexical file handles the files are closed when the handle variable goes out of scope so it unusual to need to explicitly close files
Optimising for fewest key strokes only makes sense transmitting to Pluto or beyond
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.