In addition to the suggestion to use strict;, I recommend you not rely on implicit variables.
#!/usr/bin/perl #^^^ added / after ! use warnings; open my $wave, '>', 'Wave' or die "Can't open $wave: $!"; open my $keywords, '<', 'Agents' or die "Can't open keywords: $!"; open my $search_file, '<', 'Definitions' or die "Can't open search f +ile: $!"; my $keyword_or = join '|', map {chomp;qr/\Q$_\E/} <$keywords>; close $keywords; my $regex = qr|\b($keyword_or)\b|; OUTER: while (my $line = <$search_file>) { # ^^^^^^^ using just $_ is for chodes INNER: while ($line =~ m/$regex/g) #<~ why is this a "while" an not an "i +f"? { # skip if... if ( $line =~ m/(?:SCRIPTNAME|DESCRIPTION)/ ) { #^ if you're not capturing $1, don't keep it i +n memory next INNER; # ^^^^^ labels when using "nested" loops can be very help +ful } print $wave $line; } } close $wave; close $search_file; <code> Final note, you're opening yourself up to some adversarial input attac +ks by trusting <code>$keyword_or
and blindly iterating over $search_files. Idk I think I also found an issue with your next and question your use of that inner while altogether.

In reply to Re: nesting loops help? by perlfan
in thread nesting loops help? by shadowfox

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.