Why are you relying on open to determine your type? -f works just fine on expressions, a.k.a. paths in strings.
#!/usr/bin/perl -w use latest; use File::Spec; my $test=$ARGV[0]; sub bfs { my $path=$_[0]; push(my @queue,$path); my @output; while(@queue) { $path=shift(@queue); if (-d $path) { my $dirname = (File::Spec->splitdir($path))[-1]; # Grab th +e last entry next if $dirname =~ /^\.\.?$/; # . or .. opendir my $dh,$path or die "opendir failure, $path: $!"; push @queue,map {File::Spec->catfile($path,$_)} readdir $d +h; } elsif (-f $path) { say $path; } else { # say "Other entity encountered: $path"; next } } return @output; } bfs($test);
Note I've removed the open on the files entirely, and scoped the directory handle appropriately so that Perl closes it as the variable goes out of scope. I've also used File::Spec's splitdir method to make the directory name check actually cross-platform (as long as you'd started down that path...).

#11929 First ask yourself `How would I do this without a computer?' Then have the computer do it the same way.


In reply to Re: Whenever perl meets namedpipe it gets blocked by kennethk
in thread Whenever perl meets namedpipe it gets blocked by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.