Yes, it is incorrect. You now have a $ inside braces - why have you done that?

Fixing these 8 lines in isolation gives:

     my $vmstr = "zldcdyh1bdce2d14-xxx-vccpohr-correlator-0";
     my ($opstr) = $vmstr =~ /-(\d\d)$/;    #using the value of $vmstr
+ of the VM but with an added 0
     my $OPinst = "/PMOSS_SIPNBVQM_5MIN_OHDR_$YYYYmmddHHMMSS$opstr";
     my $P3inst = "/PMOSS_P3_SIPNBVQM_5MIN_OHDR_$YYYYmmddHHMMSS$opstr"
+;


    $FN_OUTPUT    = "$DST_DIR${OPinst}_${INSTANCE}_$$";         # Suff
+ixes added later: .processing .completed
    $FN_P3_OUTPUT       ="$DST_DIR${P3inst}_${INSTANCE}_$$";     # Suf
+fixes added later: .processing .completed

[download]

Note however that $INSTANCE is undefined. It is always best to provide an SSCCE.

🦛

In reply to Re^5: appending a variable by hippo
in thread appending a variable by pragovnj

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.