I think it depends; for this module I would do this since it returns the reference if successful.
local $@; my $book = eval { Spreadsheet::Read->new($file); };
or
local $@; my $book; my $ok = eval { $book = Spreadsheet::Read->new($file); 1; };
The second example seems like "more work" to handle the error and is a lot messier. So in this case adding the "1" is superfulous since the called sub actually returns something (or doesn't).

A case where I'd use 1; with an or undef thrown in:

local $@; my $ok = eval { doSomethingButDontWantReturnValButCouldDie() or undef; 1; };
I think ultimately, the answer is like I stated above, it depends - on what you're doing and expecting; and how you tend to check for/handle exceptions.

I've also done this; but usually it's a game time decision for me.

local $@; my $ok = eval { doSomethingButDontWantReturnValButCouldDie(); 1; } or undef;

In reply to Re^3: Can I catch a die from someone else's module? by perlfan
in thread Can I catch a die from someone else's module? by bartender1382

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.